Add BayernLuft Adapter to latest

[Marco15453]

No description provided.

[Apollon77]

SUpported languages notes can be ignored

[Apollon77]

Hi, here is my review feedback:

• YOu choose a very creative way to work around node-fetch being ESM only in v3An alternative is to use https://github.com/esm2cjs/node-fetch#esm2cjsnode-fetch ... I'm also completely unsure if this have performance or memory consumption issues ... in fact it will always import it "again" - for every call ... feels suboptimal.
• Please add meaningfull translations for your field into the translation files :-) https://github.com/Marco15453/ioBroker.bayernluft/blob/main/admin/i18n/de/translations.json is dummy stuff :-)
• Please move https://github.com/Marco15453/ioBroker.bayernluft/blob/main/main.js#L57 one line on top of the setState - setState could throw an error ... clearTimeout not.
• It might be easier to remember which objects were already checked and so existing than checkig this for every calue you write in each "data read loop" This produces a lot of database traffic which is unneeded.
• Please check and adjust the roles against https://github.com/ioBroker/ioBroker/blob/master/doc/STATE_ROLES.md (e.g. string can not be "indicator"
• Please only react to state changes with ack === false (or is this the second return in stateChange but a typo?)
• While it is somehow working it is cleaner code to use await with setStateAsync instead of setState :-) (e.g. https://github.com/Marco15453/ioBroker.bayernluft/blob/3977421cec03784437a667b28fb1ed8f6fc865f4/main.js#L152)
• Please enforce meaningful minimum/limts for the pullInterval
• Maybe you want to add a timeout for the node-fetch requests and make sure that the timeouts are set in a way that the pullIntervall can not be smaller then "timeout*2" (because two calls when I got it right)

Thank you for checking and adjusting the mentioned relevant points

[Marco15453]

• It might be easier to remember which objects were already checked and so existing than checkig this for every calue you write in each "data read loop" This produces a lot of database traffic which is unneeded.

What do you exactly mean with this?

[Apollon77]

Right now whenever you receive data and want to write a state you do a getObject and then do comparisms based on that object. Given the point that datatype, unit and such not change with each data request (if this would be true we need to talk about other topics) in fact ONE getObject at the start would be enough if you simply would create a Map in the adapter wehere you remember this object by his id. So you also know the content without having to read it from the DB everytime anew

[Apollon77]

@Marco15453 Happy new year, how we should proceed?

[Marco15453]

I don't quite understand what you exactly want, if you could destribe it a bit better.

[Apollon77]

@Marco15453

I don't quite understand what you exactly want, if you could destribe it a bit better.

To which point exactly you need more information? Is it about the remember alreadyf created objects or any other point?

if it is that point then this is simply a performance topic:
In your checkDevices when you write data then you always do a "getObject" to verify if the object is existing or not. If yes you just do setState else you craete objects, but you aaalways do a getObject. And in fact you do this in any pull loop, so any x Seconds.
My idea was that you have e.g. ean object with named keys where you remember when you did the getObject check or created the object becaus ethen you do not need to do that again for thw whole run of your instance.

Is that more clear?

Innfact with a getObject you dpuble the number of requests your adapter does internally to the DB per "pull loop".

[mcm1957]

Please add node 18 test-and-release.yml and (optionally) add node 20 to testing matrix.

And in addition please REMOVE source-dist-stabel from this PR. New adapters MUST be available for some time at latest before accepted for stabel repository. So ist inappropiate to add this adapter to both repositories at once

Thanks
McM1957

[mcm1957]

PR must not change latest and stabel at the same time
Addition to stable requires that the adapter is available at latest for some time (at least a week) and have some users.

So please remove changes for stable repo from this PR

[mcm1957]

Check of bayernluefter irrelavant and caused by old commits.

❗ [E201] Bluefox was not found in the collaborators on NPM!. Please execute in adapter directory: npm owner add bluefox iobroker.bayernluft

must be fixed, further review to be done

[Apollon77]

@Marco15453 Please check the checker comments

[mcm1957]

RE-CHECK!

[github-actions]

Automated adapter checker

ioBroker.bayernluefter

• ❗ [E020] Name of adapter in package.json must be lowercase and be equal to "iobroker.bayernluefter". Now is "iobroker.bayernluft"
• ❗ [E103] "common.name" in io-package.json must be equal to "bayernluefter'". Now is bayernluft
• ❗ [E201] Bluefox was not found in the collaborators on NPM!. Please execute in adapter directory: npm owner add bluefox iobroker.bayernluefter
• ❗ [E510] "/admin/i18n/uk/translations.json" or "admin/i18n/uk.json" not found, but admin support is declared
• 👀 [W171] "common.title" is deprecated in io-package.json
• 👀 [W105] "common.titleLang" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
• 👀 [W109] "common.desc" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
• 👀 [W202] Version of package.json (1.2.2) doesn't match latest version on NPM ({"_id":"iobroker.bayernluefter","name":"iobroker.bayernluefter","time":{"created":"2022-10-31T12:27:57.986Z","1.0.0":"2022-10-31T12:27:58.198Z","modified":"2022-11-04T20:32:58.749Z","1.0.2":"2022-10-31T12:33:11.324Z","1.1.0":"2022-10-31T13:53:38.032Z","1.1.1":"2022-10-31T13:59:36.502Z","1.1.2":"2022-10-31T14:43:23.802Z","1.2.0":"2022-11-03T18:53:16.251Z","unpublished":{"time":"2022-11-04T20:32:58.749Z","versions":["1.0.0","1.0.2","1.1.0","1.1.1","1.1.2","1.2.0"]}}})
• 👀 [W400] Cannot find "bayernluefter" in latest repository

ioBroker.bayernluft

• ❗ [E510] "/admin/i18n/uk/translations.json" or "admin/i18n/uk.json" not found, but admin support is declared
• 👀 [W171] "common.title" is deprecated in io-package.json
• 👀 [W105] "common.titleLang" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
• 👀 [W109] "common.desc" should be translated into all supported languages (en, de, ru, pt, nl, fr, it, es, pl, uk, zh-cn)
• 👀 [W400] Cannot find "bayernluft" in latest repository

Add comment "RE-CHECK!" to start check anew

[mcm1957]

@Marco15453
As there was no reaction to last poll from mid 2023 and adapter has not been updated since app 2 years this PR seems to be outdated / stale.

@Marco15453
Please respond if you still want this adapter to be added to the repositories and would adapt the adapter if required after review. I'll do a new rive then.

If there is no reaction / comment until 15.04.2024 I will close this PR

Of course opening a new PR at any time is welcome.

Thanks for writing an adapter for ioBroker.

reminder 31.3.2024