Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release myvbus propose file change #684

Merged
merged 1 commit into from
Apr 7, 2020
Merged

release myvbus propose file change #684

merged 1 commit into from
Apr 7, 2020

Conversation

pdbjjens
Copy link
Contributor

No description provided.

@GermanBluefox GermanBluefox added auto-checked This PR was automatically checked for obvious criterias must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review labels Mar 30, 2020
@ioBroker ioBroker deleted a comment from Apollon77 Mar 30, 2020
@Apollon77
Copy link
Collaborator

Hi,

please also enable travis-ci. Thank you!

Additionally some review comments:

  • (needs fix) You need to encrypt passwords before storing. YOu could check my meross Adapteror other for examples.

The rest looks really great. Thank you!

@DutchmanNL
Copy link
Contributor

RE-CHECK!

@DutchmanNL
Copy link
Contributor

RE-CHECK!

travis activated

@ioBroker ioBroker deleted a comment from DutchmanNL Mar 31, 2020
@DutchmanNL DutchmanNL mentioned this pull request Apr 3, 2020
Closed
@pdbjjens
Copy link
Contributor Author

pdbjjens commented Apr 5, 2020

Password Encryption added and tested

@GermanBluefox
Copy link
Contributor

Automated adapter checker

ioBroker.myvbus

Downloads Number of Installations (latest)
NPM

👍 No errors found

  • 👀 [W400] Cannot find "myvbus" in latest repository

Add comment "RE-CHECK!" to start check anew

@ioBroker ioBroker deleted a comment from DutchmanNL Apr 5, 2020
@DutchmanNL
Copy link
Contributor

@Apollon77 password encryption added, ready for release.

I also a activated travis and all is working/green

Schermafbeelding 2020-04-05 om 10 33 59

@GermanBluefox GermanBluefox merged commit 03ed024 into ioBroker:master Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-checked This PR was automatically checked for obvious criterias must be fixed The Adapter request got review/automatic feedback that is required to be fixed before another review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pdbjjens @Apollon77 @DutchmanNL @GermanBluefox