Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add smartcontrol to Latest #930

Merged
merged 1 commit into from
Sep 22, 2020
Merged

Add smartcontrol to Latest #930

merged 1 commit into from
Sep 22, 2020

Conversation

Mic-M
Copy link
Contributor

@Mic-M Mic-M commented Sep 22, 2020

Github: https://github.com/Mic-M/ioBroker.smartcontrol
Forum: Threads tagged with smartcontrol | Current thread | Splash Page

Please review and add to Latest. A couple of comments, since I recently initiated discussions related to i18n and documentation, which were also related to this adapter, so this adapter is kind of a "hot iron" 😄 , but now it should meet all conventions and also providing a great usability for our users ;-)

  • Compact Mode successfully checked
  • https://adapter-check.iobroker.in/ looks good.
  • All 10 required translations are implemented via gulp (admin/i18n -> words.js).
  • Adapter documentation is available in English and German, both on Github and also embedded within the adapter configuration. If user's language setting is not English (en), the code checks admin/doc-md/ folder for existence of local language. If not there, English is the fallback, plus a note note (italic, blue text "Your current ioBroker language is ...") to encourage users helping in translating into their languages. Currently I have English and German as documentation.
    image

Thank you!

@GermanBluefox
Copy link
Contributor

Automated adapter checker

ioBroker.smartcontrol

Downloads Number of Installations (latest)
NPM

👍 No errors found

  • 👀 [W400] Cannot find "smartcontrol" in latest repository

Add comment "RE-CHECK!" to start check anew

@GermanBluefox GermanBluefox added the auto-checked This PR was automatically checked for obvious criterias label Sep 22, 2020
@ioBroker ioBroker deleted a comment from Apollon77 Sep 22, 2020
@Apollon77
Copy link
Collaborator

welcome

@Apollon77 Apollon77 merged commit c217252 into ioBroker:master Sep 22, 2020
@Mic-M
Copy link
Contributor Author

Mic-M commented Sep 22, 2020

Awesome 😎
Thanks!

@Mic-M Mic-M deleted the patch-2 branch September 22, 2020 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-checked This PR was automatically checked for obvious criterias
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants