Added new states for "AC0251100NJ/AC0251600NJ/AC0251700NJ" (Osram switch mini) #1379
Conversation
This was necessary so that the boolean values are also written.
states.switch_circleclick, states.switch_circlehold, states.switch_down, states.switch_downhold, states.switch_up, states.switch_uphold were added. This was necessary so that the boolean values are also written in the corresponding objects.
|
Please verify:
Note that the explicit definition of states and devices in the zigbee Adapter is deprecated and the long term plan is to remove as many of the explicit Device definitions as possible in order to limit the amount of code needed for the zigbee adapter. The above mentioned issue with states getting disconnected is a direct result of having explicitly defined devices and states within the adapter rather than relying on the exposes provided by the zigbee-herdsman-converters library. A. |
|
I think you mean with "exclude ("Ausschliessen") List" within the zigbee instance in iobroker the tab next to "binding" right? In that case the values of the objects "state", "circle", "hold" and "release" will not be changed, with or without my changes by this PR, it doesnt matter. Regarding object "battery" i cannot give a reliable answer, cause the object isnt updated that often. I already thought that this is the dirty solution, but I don't understand how to set the values of "state" (possible values with states.js: "press", "hold"), "circle" (possible values with states.js: "up", "down", "circle"), "hold" (possible values with states.js: "up", "down", "circle") and "release" (possible values with states.js: "up", "down", "circle") in the "new" way. |
|
Did you run the state cleanup to remove all the states which are no longer connected to a converter ? |
|
No I haven't yet, but before I do that, what are the consequences? Do you expect that the objects "state", "circle", "hold" and "release" will be deleted? |
|
I expect that all objects which are no longer actively supported by the exposes will be deleted. Note that if you remove the device from the exclude list and restart with your code changes active, the states will return. A. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Quick update - leaving this open until the discussed solution is in place. This has not been forgotten, but pushed back due to bug fixing and work. |
|
i think we can close here |
|
We can close it when the problem/topic is solved. Is that the case? I am not sure about that. |
|
this issue is 6 month old.. and we are at least 15 versions ahead |
|
The problem is or was that boolean objects were added and the old ones stopped working. I changed that with another PR, but then the new (boolean) ones didn't work anymore. With this PR I wanted to introduce a solution where both ways work, asgothian wanted to solve the problem in a different way. This is the current state. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Added new states for "AC0251100NJ/AC0251600NJ/AC0251700NJ" (Osram switch mini). This was necessary so that the boolean values are also written in the corresponding objects. The background is that after the last adjustment the values of the objects circle_click, circle_ hold, down, down_hold, up and up_hold were not updated: Forum entry