Skip to content

Commit

Permalink
Merge pull request #556 from ioam/columns_generators
Browse files Browse the repository at this point in the history
Fixed generator check on DataColumns
  • Loading branch information
jlstevens committed Mar 14, 2016
2 parents d4779cb + bcfdf14 commit 84b258e
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
3 changes: 1 addition & 2 deletions holoviews/core/data.py
Original file line number Diff line number Diff line change
Expand Up @@ -424,8 +424,7 @@ def initialize(cls, eltype, data, kdims, vdims, datatype=None):
data = data.data
elif isinstance(data, Element):
data = tuple(data.dimension_values(d) for d in kdims+vdims)
elif (not (util.is_dataframe(data) or isinstance(data, (tuple, dict, np.ndarray, list)))
and sys.version_info.major >= 3):
elif isinstance(data, util.generator_types):
data = list(data)

# Set interface priority order
Expand Down
4 changes: 4 additions & 0 deletions holoviews/core/util.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,16 @@
bz = None

# Python3 compatibility
import types
if sys.version_info.major == 3:
basestring = str
unicode = str
generator_types = (zip, range, types.GeneratorType)
else:
basestring = basestring
unicode = unicode
from itertools import izip
generator_types = (izip, xrange, types.GeneratorType)


def process_ellipses(obj, key, vdim_selection=False):
Expand Down

0 comments on commit 84b258e

Please sign in to comment.