Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obisissues.py is unused? #72

Closed
7yl4r opened this issue Aug 23, 2022 · 1 comment · Fixed by #77
Closed

obisissues.py is unused? #72

7yl4r opened this issue Aug 23, 2022 · 1 comment · Fixed by #77
Assignees
Labels
discussion needed open discussion. your input is needed! enhancement

Comments

@7yl4r
Copy link
Collaborator

7yl4r commented Aug 23, 2022

obisissues is a module which is essentially just a lookup table for error codes coming from the API. I don't think we are using this, and I am also uncertain if this module is up-to-date. We could remove the module, but we may also want to retain it for future use. Some text noting this at the top of the file might be sufficient, or we could keep it in a separate branch. I am not sure what is the best practice for retaining legacy code.

@7yl4r 7yl4r added enhancement discussion needed open discussion. your input is needed! labels Aug 23, 2022
@7yl4r
Copy link
Collaborator Author

7yl4r commented Aug 30, 2022

@ayushanand18 tested some of this and found that the error codes are out of date. The current OBIS API error codes are more self-explanitory.

This file was adapted from pyGBIF, and may never have been valid for the OBIS API.

With this in mind I am deleting the file and closing this issue. Here is a reference to the file if needed in the future: https://github.com/iobis/pyobis/blob/d0aa1a5996dcea57d414592300ed6eef08561b5e/pyobis/obisissues.py

@7yl4r 7yl4r self-assigned this Aug 30, 2022
@7yl4r 7yl4r closed this as completed in #77 Aug 31, 2022
7yl4r added a commit that referenced this issue Aug 31, 2022
Delete obisissues.py to close #72
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion needed open discussion. your input is needed! enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant