Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating notebooks after feature upgrade #81

Merged
merged 8 commits into from
Sep 4, 2022

Conversation

ayushanand18
Copy link
Collaborator

Overview

This PR aims to update all notebooks after the recent feature upgrade. Only code changes have been applied and no change analysis has been done.

Thanks!

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ayushanand18 ayushanand18 marked this pull request as ready for review September 2, 2022 04:26
@7yl4r
Copy link
Collaborator

7yl4r commented Sep 4, 2022

Should we change the google colab links from

https://colab.research.google.com/github/ayushanand18/pyobis/blob/dataset-analysis/notebooks/contributions_quantification.ipynb

to

https://[...]/github/iobis/pyobis/blob/master/[...]

?

@7yl4r 7yl4r merged commit 0ed0379 into iobis:master Sep 4, 2022
@ayushanand18
Copy link
Collaborator Author

Should we change the google colab links from

https://colab.research.google.com/github/ayushanand18/pyobis/blob/dataset-analysis/notebooks/contributions_quantification.ipynb

to

https://[...]/github/iobis/pyobis/blob/master/[...]

?

You are right, we might need to change that. I'll bring those changes in another PR along with the occurrence fix.

PS. I was sleeping when the merge happened, I'm sorry :)

@ayushanand18 ayushanand18 deleted the notebooks-update branch September 5, 2022 03:43
@7yl4r
Copy link
Collaborator

7yl4r commented Sep 5, 2022

No worries! Gotta sleep sometime!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants