Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Cheapest Station Boolean true even if not cheapest #111

Closed
1 task done
Diginix opened this issue Jan 2, 2023 · 13 comments
Closed
1 task done

[Bug]: Cheapest Station Boolean true even if not cheapest #111

Diginix opened this issue Jan 2, 2023 · 13 comments
Labels
bug

Comments

@Diginix
Copy link

Diginix commented Jan 2, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

3 of 4 stations has price 1.699 and one has 1.719. All 4 stations has cheapest = true

What did you expect to happen?

No response

How to reproduce it (minimal and precise)

No response

Adapter version

3.3.2

Environment

- Node: 16.19.9
- npm: 8.19.3
- JS-Controller: 4.0.24
- Operating system: Ubuntu LTS

What browsers are you seeing the problem on?

No response

Screenshots & Log

image
@Diginix Diginix added the bug label Jan 2, 2023
@xXBJXx
Copy link
Contributor

xXBJXx commented Jan 2, 2023 •
edited
Loading

Check if tankerkoenig.0.stations.cheapest.e5.cheapest_stations also contains the station

@Diginix
Copy link
Author

Diginix commented Jan 2, 2023

No this JSON contains only the 3 correct ones.

@xXBJXx
Copy link
Contributor

xXBJXx commented Jan 2, 2023

Is the station closed or open?

@Diginix
Copy link
Author

Diginix commented Jan 2, 2023

open

@xXBJXx
Copy link
Contributor

xXBJXx commented Jan 2, 2023

ok i will look at it again

@Diginix
Copy link
Author

Diginix commented Jan 2, 2023

All 4 are in the same city and has the same "conditions" atm. Only the boolean flag seams not to be toggled if another one becomes cheaper.

@xXBJXx
Copy link
Contributor

xXBJXx commented Jan 2, 2023

I cannot reproduce the error, I have now created 7 stations and run the times a few hours, let the flag is set as well as the names in the tankerkoenig.0.stations.cheapest.e5.cheapest_stations.
Was the state about have updated ⇨
image

@Diginix
Copy link
Author

Diginix commented Jan 2, 2023 •
edited
Loading

Also the update time was the same as for all other stations.
At the moment the real cheapest station is flaged, all others not.
I have 8 stations, 4 for 2 different cities. But this doesn't matter for the logic. Only the cheapest price over all should be flagged. No matter how much stations. I will have a look if it happens again. But I don't know what more I could provide for finding the cause.
btw: I use E10, not E5

@xXBJXx
Copy link
Contributor

xXBJXx commented Jan 2, 2023 •
edited
Loading

btw: I use E10, not E5

Maybe you should have said that earlier because there is a bug because not the e10, but the e5 are displayed, I have had a written error in the variable.
That could be the problem.

@xXBJXx
Copy link
Contributor

xXBJXx commented Jan 2, 2023

I fix it in version 3.3.3

@Diginix
Copy link
Author

Diginix commented Jan 2, 2023

Sorry, doesn't thought that the fuel type could matter. But good to hear that you found something related.

@smartcuc
Copy link

smartcuc commented Jan 2, 2023 •
edited
Loading

Cool. Having the same issue und good to hear, that there will be fix.

xXBJXx added a commit that referenced this issue Jan 2, 2023
@xXBJXx
does not fetch data after a requestData error and fixed Issue #111
3424bc0
xXBJXx added a commit that referenced this issue Jan 2, 2023
@xXBJXx
chore: release v3.3.3
c5e95bf 
* (xXBJXx) fixed => adapter does not fetch data after a `requestData error` e.g. internet termination.
* (xXBJXx) add adapter migration Guide from 3.1.x to 3.3.x or 3.2.x to 3.3.x [Migration guide](docs/guide/migration_3.3.x.md)
* (xXBJXx) fixed Issue [Issue #111](#111)
@xXBJXx
Copy link
Contributor

xXBJXx commented Jan 22, 2023

Released in v3.3.3

@xXBJXx xXBJXx closed this as completed Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@smartcuc @xXBJXx @Diginix