This repository has been archived by the owner on Apr 4, 2024. It is now read-only.
Optional plugin branch property #1250
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
I want to mention this would be very helpful for me trying to move MotionEye from Python 2 to Python 3 without breaking things as I wait for the manifest.json to be updated and then not breaking things once it is until I can update the artefact repo. It would also enable (combined with the release versioning of the manifest.json) maintaining support for stable/old releases of TrueNAS while still supporting the newest during a period of transition like we went through with 12 to 13. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new optional
branchplugin property to the manifest. Setting this property in the plugin manifest will clone/pull the plugin artifact from that branch rather than the TrueNAS FreeBSD version and if not present/set fallback to the pluginmasterbranch. This way the plugin version can be locked/updated in a more controlled manner and not depend on the TrueNAS (FreeBSD) version which would otherwise automatically update a plugin during a new release.Related (Closes?) PR/discussion: #1248
Make sure to follow and check these boxes before submitting a PR! Thank you.