Change bug status in 1992/gson #2554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed extraneous </p>.
This was caused because I had accidentally put a leftbar class before the '*' rather than on the same line (after it). This commit should fix it.
An additional look shows that the gets(3) call is for the dictionary file. It is highly unlikely (though not impossible) that the dictionary file would ever have a line 256 in length and this as well as because it was documented is why I changed the buffer size back to the original. The bug status does still suggest it would be nice if fgets(3) could be used but it also lists the bugs and limitations the author stated in the first place which actually does refer to the 256 limit. I moved the notice to those who want a challenge up a bit in the README.md file to be right above obfuscatory notes rather than before those notes get into the details.
|
Have to go for a bit .. when back I'll be doing more on the 'challenge' notes .. then hopefully I can finish the most recent issue and then go from there. I forgot to say that this commit also fixes some format problems in the index.html file. |
lcn2
approved these changes
Jul 9, 2024
Welcome .. afk a bit longer and then I hope to do more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An additional look shows that the gets(3) call is for the dictionary
file. It is highly unlikely (though not impossible) that the dictionary
file would ever have a line 256 in length and this as well as because it
was documented is why I changed the buffer size back to the original.
The bug status does still suggest it would be nice if fgets(3) could be
used but it also lists the bugs and limitations the author stated in the
first place which actually does refer to the 256 limit.
I moved the notice to those who want a challenge up a bit in the
README.md file to be right above obfuscatory notes rather than before
those notes get into the details.