-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix lat,lon ordering and point separation in polygon examples #364
Conversation
Updated the ODIS-WIS2 README.md to provide comprehensive notes and TODOs for aligning OIH holdings to WMO.
….com> Co-authored-by: Jeff McKenna <jmckenna@gatewaygeomatics.com> Co-authored-by: OceandataJo <joevstaasodp@users.noreply.github.com>
add INVEMAR Geo endpoint to ODIS config
add INVEMAR Geo endpoint (fix formatting)
add NMDIS-China to ODIS config
update sitemapCheck action to use master config
update Dashboard to use master config
[config] point to new raw data location
@marksparkza thanks for the coordinate changes. I wonder about your proposed no space after the comma, as I see other examples with a space after the comma. |
I suspect that JSON-LD processors may be lenient in this regard - i.e. allow either space or no space after the comma. I am essentially following the schema.org recommendation of "Either whitespace or comma" as lat-lon separator. I opted for the comma because I think (my perception, ymmv) that it is easier to visually pick points out of a series if each lat-lon pair is joined with a comma. |
@marksparkza I agree with your thoughts on this, and reasoning. I am +1 for these changes. |
@marksparkza thanks very much for your keen eye on this, it is very much appreciated. Merging... |
@marksparkza oh I just noticed (we recently changed to doing all updates into |
2fc75ae
to
1804327
Compare
I've rebased onto master; closing this PR and will open a new one |
Examples of
polygon
have been incorrectly formatted as"lon lat"
pairs separated by commas. According to schema.org's definition of GeoShape, point pairs should be formatted either as"lat lon"
or"lat,lon"
, and points should be separated by whitespace, not commas.