Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run snapshot tests based on storybook #2506

Merged
merged 1 commit into from
Dec 3, 2019

Conversation

wlach
Copy link
Contributor

@wlach wlach commented Dec 3, 2019

This provides some additional assurance that PRs don't break aspects
of the UI.

Pull Request checklist

  • [N/A] Documentation: If this feature has or requires documentation, the relevant docs have been updated.
  • [N/A] Changelog: This PR updates the changelog with any user-visible changes.
  • Tests: This PR includes thorough tests or an explanation of why it does not

@codecov
Copy link

codecov bot commented Dec 3, 2019

Codecov Report

Merging #2506 into master will increase coverage by 1.06%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2506      +/-   ##
=========================================
+ Coverage   69.74%   70.8%   +1.06%     
=========================================
  Files         223     236      +13     
  Lines        5530    5769     +239     
  Branches      894     928      +34     
=========================================
+ Hits         3857    4085     +228     
- Misses       1654    1665      +11     
  Partials       19      19
Impacted Files Coverage Δ
.storybook/config.js 100% <ø> (ø)
src/reps/__stories__/reps.stories.js 25% <100%> (ø)
src/editor/components/modals/modal-container.js 100% <0%> (ø)
...__stories__/drop-target/components/FileManager.jsx 57.5% <0%> (ø)
...rc/reps/serialization/get-top-level-rep-summary.js 100% <0%> (ø)
src/reps/__stories__/table-rep.stories.js 100% <0%> (ø)
..._stories__/drop-target/components/ImageGallery.jsx 42.5% <0%> (ø)
...sources/__stories__/manage-file-sources.stories.js 71.42% <0%> (ø)
... and 14 more

This provides some additional assurance that PRs don't break aspects
of the UI. We are excluding some reps tests which are non-deterministic
for now.
@wlach
Copy link
Contributor Author

wlach commented Dec 3, 2019

Some of the reps test don't pass because they output non-deterministic stack information. Should be fixable in a followup, in the meantime this would have caught the recent react table brokenness.

@wlach wlach requested a review from hamilton December 3, 2019 22:17
Copy link
Contributor

@hamilton hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@wlach wlach merged commit 00d8d30 into iodide-project:master Dec 3, 2019
@wlach wlach deleted the storybook-tests branch December 3, 2019 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants