Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MNT Use Brotli compression for package artifacts #770

Merged
merged 7 commits into from
Oct 20, 2020
Merged

Conversation

rth
Copy link
Member

@rth rth commented Oct 18, 2020

Use Brotli compression on built packages before uploading them to the artifact storage, as suggested by @MartinKolarik

Should have no impact on users, but should reduce the download size (and therefore data transfer costs) between the artifact storage and the CDN.

(I tested earlier that this is working fine).

@MartinKolarik
Copy link

Note that this will NOT work in your current setup because CF doesn't support fetching brotli files from the origin.

@rth
Copy link
Member Author

rth commented Oct 19, 2020

Thanks @MartinKolarik . What I checked previously was that is you upload them br compressed, CF will serve them fine with the associated header. However if the request is Accept-Encoding:gzip it will indeed fail to re-encode them to gzip. So I guess for now are limited to gzip compression at the origin which should be supported by CF.

@rth rth merged commit 49dc822 into master Oct 20, 2020
@rth rth deleted the brotli-compression branch October 20, 2020 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants