doc: update AUTHORS list #713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| @@ -691,5 +691,14 @@ Xiaowei Li <446240525@qq.com> | |||
| toastynerd <tylermorgan86@gmail.com> | |||
| Todd Kennedy <toddself@users.noreply.github.com> | |||
| Icer Liang <wizicer@users.noreply.github.com> | |||
| Stephen Belanger <admin@stephenbelanger.com> | |||
| Fishrock123 <fishrock123@rocketmail.com> | |||
There was a problem hiding this comment.
Can we add a .mailmap entry for @Fishrock123?
|
@rvagg Can we get this in for 1.2.0? |
rvagg
force-pushed
the
update-authors
branch
from
0aa3e06
to
78000d6
Compare
|
updated to current HEAD with 4 more entries and a .mailmap entry for @Fishrock123, will wait to hear from @3674823674252 before I merge this. |
Update AUTHORS file using tools/update-authors.sh PR-URL: nodejs#713 Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
rvagg
force-pushed
the
update-authors
branch
from
78000d6
to
d832be4
Compare
|
merged @ d832be4, will update .mailmap next time if @3674823674252 expresses an opinion but I'll leave it as is for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update AUTHORS file using tools/update-authors.sh
I think I've also discovered that my clever Awk program doesn't work properly on OSX, something about ordering I think. Need to fix that somehow. For now I'm just doing an update.