Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Intel based MacOS and Windows #73

Merged
merged 3 commits into from
Dec 28, 2023

Conversation

Fabi755
Copy link
Contributor

@Fabi755 Fabi755 commented Dec 23, 2023

Fixes #68

@StefMa
Copy link
Collaborator

StefMa commented Dec 23, 2023

Hey @Fabi755 ,

thanks for the contribution ☺.
Could you maybe use the universal version of the cli for macOS?!
Please also add the windows version so we can close #68

@Fabi755
Copy link
Contributor Author

Fabi755 commented Dec 27, 2023

I'm not really sure, if the Windows implementation is correct. I have orientated on the Sentry install script.

@StefMa StefMa changed the title Add support for Intel based MacOS Add support for Intel based MacOS and Windows Dec 27, 2023
@StefMa
Copy link
Collaborator

StefMa commented Dec 27, 2023

Thanks. I think this is good enough.
Did you tested it with the universal cli? 😁

@Fabi755
Copy link
Contributor Author

Fabi755 commented Dec 27, 2023

Did you tested it with the universal cli? 😁

Yes, with my Intel Chip MacBook it works :-)

@StefMa StefMa merged commit f2b9c48 into ioki-mobility:main Dec 28, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support more architectures (via sentry cli)
2 participants