Add optional create collection params #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsjethani
requested changes
Aug 2, 2023
collections.go
Outdated
Comment on lines
144
to
147
| func newCollectionsCreateClient(sl *sling.Sling, params collectionsCreateParams) *CollectionsCreateClient { | ||
| copy := sl.New() | ||
| copy.Post(common.CollectionsCreateEndpoint()).BodyJSON(&data) | ||
| return &CollectionsCreateClient{sl: copy, params: params} | ||
| } |
There was a problem hiding this comment.
second parameter should be name only and while returning the new CollectionsCreateClient give it a new param with name field initialized from the name parameter
|
@rsjethani in case you are fine with my changes, you can approve it directly. |
rsjethani
approved these changes
Aug 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27
Follows the same pattern as in #20