Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine release workflow #57

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Refine release workflow #57

merged 2 commits into from
Aug 29, 2023

Conversation

rsjethani
Copy link
Collaborator

@rsjethani rsjethani commented Aug 21, 2023

  • Only fetch code w.r.t specifed tag rather than all history.

  • Automate Go version to setup: Find current Go version of the module
    and then setup exactly that version of Go.

  • Change release name to only the tag name as the release is not just
    for the CLI but also for the API.

  • In goreleaser config, consistently use full tag name rather than a
    mixture of tag name and version.

  • Change gorelease config file extension to .yml for consistency.

@rsjethani rsjethani self-assigned this Aug 21, 2023
@rsjethani rsjethani requested a review from StefMa August 21, 2023 22:28
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
@rsjethani rsjethani requested a review from StefMa August 25, 2023 08:11
- Only fetch code w.r.t specifed tag rather than all history.

- Automate Go version to setup: Find current Go version of the module
and then setup exactly that version of Go.

- Change release name to only the tag name as the release is not just
for the CLI but also for the API.

- In goreleaser config, consistently use full tag name rather than a
mixture of tag name and version.

- Change gorelease config file extension to `.yml` for consistency.
Copy link
Collaborator

@StefMa StefMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rsjethani rsjethani merged commit bd88443 into main Aug 29, 2023
3 checks passed
@rsjethani rsjethani deleted the release-workflow-refinements branch August 29, 2023 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants