Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acutal HTTP request making infrastructure #9

Merged
merged 1 commit into from
Jul 7, 2023
Merged

Acutal HTTP request making infrastructure #9

merged 1 commit into from
Jul 7, 2023

Conversation

rsjethani
Copy link
Collaborator

The new request() function is what makes the actual HTTP transaction. The higher level APIs simply prepare the request based on resource type, HTTP method etc. and then call this function to do the real job.

@rsjethani
Copy link
Collaborator Author

cc @chb-ioki @StefMa

request.go Show resolved Hide resolved
StefMa
StefMa previously approved these changes Jul 4, 2023
Copy link
Collaborator

@StefMa StefMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarified in a call.
:shipit:

@rsjethani rsjethani self-assigned this Jul 6, 2023
The new `request()` function is what makes the actual HTTP transaction.
The higher level APIs simply prepare the request based on resource type,
HTTP method etc. and then call this function to do the real job.
Copy link
Collaborator

@StefMa StefMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@StefMa StefMa merged commit 34ebd34 into ioki-mobility:main Jul 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants