New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't send nil headers #104

Merged

rmehner merged 1 commit into main from features/no-nil-headers

Jun 15, 2022

Collaborator

phylor commented Jun 15, 2022

We currently send the string nil as a header value for headers without a value. Upon request of @ans-ioki, we now don't send those headers at all.


          Change not to send nil headers

55e9925

phylor marked this pull request as ready for review

June 15, 2022 10:22

phylor requested a review from rmehner

June 15, 2022 10:22

rmehner approved these changes

View reviewed changes

Collaborator

rmehner commented Jun 15, 2022

🤔 This is somewhat of a breaking change, but since we're not 1.0 yet, it's fine I guess. Should get a own release tho.

rmehner merged commit 4892926 into main

rmehner deleted the features/no-nil-headers branch

June 15, 2022 11:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment