Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Rubocop and other dependencies #139

Merged
merged 2 commits into from Oct 25, 2022
Merged

Update Rubocop and other dependencies #139

merged 2 commits into from Oct 25, 2022

Conversation

rmehner
Copy link
Collaborator

@rmehner rmehner commented Oct 25, 2022

This fixes the issue:

Error: unrecognized cop or department RSpec/SortMetadata found in .rubocop-https---dbdrive-github-io-triebwerk-rubocop-common-yml
Did you mean `RSpec/ScatteredLet`?

It includes a lot of changes to the specs as a result of running rubocop again after the updates.

I've also updated the rest of the deps while at it.

@rmehner rmehner requested a review from phylor October 25, 2022 15:09
@rmehner
Copy link
Collaborator Author

rmehner commented Oct 25, 2022

This fixes the build for #138

@rmehner rmehner mentioned this pull request Oct 25, 2022
Merged
phylor
phylor approved these changes Oct 25, 2022
View reviewed changes
Copy link
Collaborator

@phylor phylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎖️

@phylor phylor merged commit aeeefb9 into main Oct 25, 2022
@phylor phylor deleted the chores/update-gemfile-deps branch October 25, 2022 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phylor phylor phylor approved these changes

Assignees
No one assigned
Labels
PR: ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rmehner @phylor