Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, ioki-ruby is not able to handle errors that have a non-json response body (e.g. some errors like
404
-ActiveRecord::RecordNotFound
come with a 'text/html' response body). Reason being, theJsonParse
middleware of Faraday tries to parse the response body to json no matter what. This however causes ioki-ruby to raise aFaraday::ParsingError
when the response body is not a json.This PR will add the
content_typ
setting to the JsonParse middleware of Faraday which ensures that only response bodies of type json will be parsed. Response bodies of any other type will not be parsed and thus will not raise the infamousFaraday::ParsingError
.