PassengerAPI | Fix updating language #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HTTP adapter is initialized when the configuration is initialized. When changing the language later, the client still uses the old values. We therefore have to reinitialize the HTTP adapter when the config is changed.
tom-ioki
approved these changes
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
Passenger#update_languageendpoint doesn't work as expected.What should happen:
my_passenger_client.update_language('fr')PATCH /api/passenger/user/languageand sets theAccept-Languageheader tofr. That header is used to set the language. There is no body or path parameters.What actually happens:
Ioki::Configuration. At that point the language is taken from the configuration and an HTTP adapter is initialized asconfig.http_adapterwith that language.my_passenger_client.update_language('fr')config.languageto the new language and then makes the HTTP requestSo we have to re-initialize the HTTP adapter, so that the new language takes effect and is sent as the HTTP header.