Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation: Rename driver pin to password #192

Merged
merged 4 commits into from Mar 20, 2023
Merged

Conversation

tom-ioki
Copy link
Contributor

@tom-ioki tom-ioki commented Feb 22, 2023

Closes #191

This PR will take care of the deprecated attribute pin.

Affected namespaces:

operator api

  • custom endpoints renamed
  • pin removed and password added to Driver model

platform api

  • custom endpoint set_password added
  • set_pin is still in place until all clients have applied the required changes

driver api

  • password added to DriverRequestToken model
  • pin is still in place until all clients have applied the required changes

Copy link

@eis-ioki eis-ioki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@tom-ioki
Copy link
Contributor Author

Still waiting for team operator 👍 Will merge as soon as possible

@tom-ioki tom-ioki merged commit 3511e55 into main Mar 20, 2023
@tom-ioki tom-ioki deleted the deprecate-driver-pin branch March 20, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation: driver's pin will be renamed to password
2 participants