Adds current_ride endpoint to passenger API #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eikes
force-pushed
the
passenger_api_improvements
branch
from
8a05996
to
ca53476
Compare
A5308Y
approved these changes
Apr 19, 2022
| @@ -31,8 +31,7 @@ | |||
| result_with_index_data | |||
| end | |||
|
|
|||
| expect(passenger_client.products(options)). | |||
| to eq([Ioki::Model::Passenger::Product.new]) | |||
| expect(passenger_client.products(options)).to all(be_a(Ioki::Model::Passenger::Product)) | |||
There was a problem hiding this comment.
Looks nicer to me, but technically we lose some specificity because we don't test anymore that the result is the "empty" version of a product.
There was a problem hiding this comment.
True! But given that there are no attributes, this isn't very meaningful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.