Add line and line stop to plattform api #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozb-ioki
added
the
PR: playing around
ozb-ioki
added
PR: ready for review
and removed
PR: playing around
tom-ioki
requested changes
May 25, 2022
lib/ioki/apis/platform_api.rb
Outdated
| ), | ||
| Endpoints.crud_endpoints( | ||
| :line_stop, | ||
| base_path: [API_BASE_PATH, 'lines', :id], |
There was a problem hiding this comment.
I guess line_stops are also part of the product resource. In that case you need to adjust the base_path to:
base_path: [API_BASE_PATH, 'products', :id, 'lines', :id]| @@ -0,0 +1,20 @@ | |||
| # frozen_string_literal: true | |||
There was a problem hiding this comment.
All attributes that can be send to triebwerk via platform api (see LineSchema and LineUpdateSchema) should have the on: [:create, :read, :update] setting. Otherwise, these attributes will get filtered out of the request on create or update.
Thank you for the review Tom. I will look on it and apply the changes. Edit: All changes are applied. |
ozb-ioki
force-pushed
the
add-line-and-line-stop-to-plattform-api
branch
from
4130b76
to
ef46d37
Compare
tom-ioki
approved these changes
May 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.