Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Anchors for Code #75

Closed
wants to merge 6 commits into from
Closed

Conversation

desttinghim
Copy link

@desttinghim desttinghim commented Aug 9, 2020

This pull request switches the code include statements to using anchors instead of line numbers. There are a couple of other minor tweaks to the tutorial to try and clarify some bits I thought were confusing. Once merged, this pull implements the anchor part of #46, no attempt has been made to use diffs yet.

@desttinghim desttinghim changed the title WIP: Use Anchors for Code Use Anchors for Code Aug 9, 2020
@desttinghim
Copy link
Author

I've edited most of the tutorials to use the anchors. I'm going to leave out 3.4 because I think it needs some rewrites to take into account the info I brought up in #74.

@iolivia
Copy link
Owner

iolivia commented Aug 15, 2020

hey @desttinghim, this is awesome, thanks so much! do you mind splitting this into a couple of separate PRs please? maybe we can start with the first two chapters, otherwise this is a bit too big to review properly and there's a good chance some code will go missing from the book, had that before and it's a pain.

@desttinghim
Copy link
Author

That is okay by me. Give me a bit to get the PR's up

@iolivia
Copy link
Owner

iolivia commented Aug 15, 2020

no rush at all 😄

@iolivia iolivia mentioned this pull request Aug 15, 2020
@iolivia
Copy link
Owner

iolivia commented Aug 16, 2020

@desttinghim I just merged a PR which moves some of the files around to support translations, it might be a pain to merge directly so might be worth just starting a new branch and copying your version of the files to the new place. sorry for the hassle!

@desttinghim
Copy link
Author

That was my plan in the first place, so no worries :)

@desttinghim
Copy link
Author

I'll close this PR since we're going to phase out it's changes over multiple.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants