Skip to content

Commit

Permalink
IOMAD: cached URLs causing issues with company URLs on URL resource t…
Browse files Browse the repository at this point in the history
…ypes. Make them relative links
  • Loading branch information
turf212 committed Sep 22, 2023
1 parent a2b71a6 commit 1710f85
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion mod/page/lib.php
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,7 @@ function page_get_coursemodule_info($coursemodule) {
return $info;
}

$fullurl = "$CFG->wwwroot/mod/page/view.php?id=$coursemodule->id&inpopup=1";
$fullurl = "/mod/page/view.php?id=$coursemodule->id&inpopup=1";
$options = empty($page->displayoptions) ? [] : (array) unserialize_array($page->displayoptions);
$width = empty($options['popupwidth']) ? 620 : $options['popupwidth'];
$height = empty($options['popupheight']) ? 450 : $options['popupheight'];
Expand Down
4 changes: 2 additions & 2 deletions mod/resource/lib.php
Original file line number Diff line number Diff line change
Expand Up @@ -232,15 +232,15 @@ function resource_get_coursemodule_info($coursemodule) {
$display = resource_get_final_display_type($resource);

if ($display == RESOURCELIB_DISPLAY_POPUP) {
$fullurl = "$CFG->wwwroot/mod/resource/view.php?id=$coursemodule->id&redirect=1";
$fullurl = "/mod/resource/view.php?id=$coursemodule->id&redirect=1";
$options = empty($resource->displayoptions) ? [] : (array) unserialize_array($resource->displayoptions);
$width = empty($options['popupwidth']) ? 620 : $options['popupwidth'];
$height = empty($options['popupheight']) ? 450 : $options['popupheight'];
$wh = "width=$width,height=$height,toolbar=no,location=no,menubar=no,copyhistory=no,status=no,directories=no,scrollbars=yes,resizable=yes";
$info->onclick = "window.open('$fullurl', '', '$wh'); return false;";

} else if ($display == RESOURCELIB_DISPLAY_NEW) {
$fullurl = "$CFG->wwwroot/mod/resource/view.php?id=$coursemodule->id&redirect=1";
$fullurl = "/mod/resource/view.php?id=$coursemodule->id&redirect=1";
$info->onclick = "window.open('$fullurl'); return false;";

}
Expand Down
4 changes: 2 additions & 2 deletions mod/url/lib.php
Original file line number Diff line number Diff line change
Expand Up @@ -226,15 +226,15 @@ function url_get_coursemodule_info($coursemodule) {
$display = url_get_final_display_type($url);

if ($display == RESOURCELIB_DISPLAY_POPUP) {
$fullurl = "$CFG->wwwroot/mod/url/view.php?id=$coursemodule->id&redirect=1";
$fullurl = "/mod/url/view.php?id=$coursemodule->id&redirect=1";
$options = empty($url->displayoptions) ? [] : (array) unserialize_array($url->displayoptions);
$width = empty($options['popupwidth']) ? 620 : $options['popupwidth'];
$height = empty($options['popupheight']) ? 450 : $options['popupheight'];
$wh = "width=$width,height=$height,toolbar=no,location=no,menubar=no,copyhistory=no,status=no,directories=no,scrollbars=yes,resizable=yes";
$info->onclick = "window.open('$fullurl', '', '$wh'); return false;";

} else if ($display == RESOURCELIB_DISPLAY_NEW) {
$fullurl = "$CFG->wwwroot/mod/url/view.php?id=$coursemodule->id&redirect=1";
$fullurl = "/mod/url/view.php?id=$coursemodule->id&redirect=1";
$info->onclick = "window.open('$fullurl'); return false;";

}
Expand Down

0 comments on commit 1710f85

Please sign in to comment.