Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancelling add user page goes back to add user page. #8

Closed
turf212 opened this issue Jan 23, 2014 · 0 comments
Closed

Cancelling add user page goes back to add user page. #8

turf212 opened this issue Jan 23, 2014 · 0 comments
Assignees
@turf212
Labels
bug

Comments

@turf212
Copy link
Collaborator

turf212 commented Jan 23, 2014

Add user page
Where is cancel button supposed to go – when I tried it after adding a user it went to add user page
@ghost ghost assigned turf212 Jan 23, 2014
turf212 added a commit that referenced this issue Feb 26, 2014
@turf212
IOMAD: some updates on the user create forms. Closes #8. Closes #9
404fcc3
turf212 added a commit that referenced this issue Aug 13, 2014
@turf212
IOMAD: some updates on the user create forms. Closes #8. Closes #9
56b79e8
turf212 pushed a commit that referenced this issue Oct 25, 2017
@actXc
Merge pull request #8 from iomad/IOMAD_33_STABLE
69ed89f 
get fresh iomad
actXc referenced this issue in actXc/iomad Jun 3, 2018
issue #8: create function to remove <span> tags on form submit
20f457e 
All the logic to remove the tags is coded inside the 'on' method closure, because seems that is not possible to define a class function that is accessible from closure scope.
actXc referenced this issue in actXc/iomad Jun 3, 2018
issue #8: FINALLY, delete properly the span tags before submission
304c66b 
The code that was in the closure is now in a function. I find it more clear.
actXc referenced this issue in actXc/iomad Jun 3, 2018
issue #8: refactoring; leave only "set HTML" not to write &nbsp; in p…
8b6cd5e 
…lain text

A RegExp object is used to create the regular expression with a variable value.
actXc referenced this issue in actXc/iomad Jun 3, 2018
issue #8: add function to add span decoration at editor load
e20f235 
In this case, we DON'T HAVE TO CALL TO markUpdated(). Why? Honestly, I don't know. But, if we call it after setting the HTML, the {mlang} tags flicker with the decoration, and returns to their original state.
actXc referenced this issue in actXc/iomad Jun 3, 2018
issue #8: create function to get HTML without {mlang}'s <span> tags
dd7179c 
... To process the HTML on init using this, instead of building an evil regular expression to find only {mlang} tags that are not involved in their <span> tag.
actXc referenced this issue in actXc/iomad Jun 3, 2018
issue #8: update behat tests
c39c68e
actXc referenced this issue in actXc/iomad Jun 3, 2018
issue #8: find also <span> tags with "id" attributes for the cleanup
c2fded1 
It has been done in two different steps to avoid evil regex.
actXc referenced this issue in actXc/iomad Jun 3, 2018
issue #8: refactoring; The cleanup with "id" attribute and without it…
a5b037a 
… is made separately, to avoid an evil regular expression.
actXc referenced this issue in actXc/iomad Jun 3, 2018
issue #8: fix bug that was creating nested <span> on editor init
e792994 
Every different {mlang} tag has to be replaced only once, otherwise, nested <span>s will be created in every repeated replacement. So, we have to have a track of which replacements have been made.
actXc referenced this issue in actXc/iomad Jun 3, 2018
Merge branch 'issue #8'
7d6b007
actXc referenced this issue in actXc/iomad Jun 3, 2018
Merge branch 'master' into issue #4: port changes merged from issue #8 …
d7bb97b 
…to master

Conflicts:
	yui/build/moodle-atto_multilang2-button/moodle-atto_multilang2-button-coverage.js
	yui/build/moodle-atto_multilang2-button/moodle-atto_multilang2-button-debug.js
	yui/build/moodle-atto_multilang2-button/moodle-atto_multilang2-button-min.js
	yui/build/moodle-atto_multilang2-button/moodle-atto_multilang2-button.js
	yui/src/button/js/button.js
actXc referenced this issue in actXc/iomad Jun 3, 2018
@dthies
Fix alignment with htmlplus in Boost #8
6d96de1
actXc referenced this issue in actXc/iomad Jun 3, 2018
@abgreeve
Merge pull request #8 from junpataleta/MOODLE_34_STABLE
24cc96f 
Set version requirement, bump version and set maturity to beta
actXc referenced this issue in actXc/iomad Jun 3, 2018
@sarjona
Merge pull request #8 from mihailges/tool-policy-34-add-behat-tests
01375e6 
Create behat tests
@sgvfr sgvfr mentioned this issue Jan 31, 2023
Closed
@sgvfr sgvfr mentioned this issue Apr 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@turf212 turf212

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@turf212