Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CSI deployment #17

Merged
merged 1 commit into from
Sep 24, 2020
Merged

Update CSI deployment #17

merged 1 commit into from
Sep 24, 2020

Conversation

weipengzhu
Copy link
Contributor

No description provided.

@weipengzhu weipengzhu marked this pull request as draft September 23, 2020 02:28
@weipengzhu weipengzhu marked this pull request as ready for review September 23, 2020 03:16
@weipengzhu weipengzhu self-assigned this Sep 23, 2020
@weipengzhu weipengzhu changed the title WIP Update CSI deployment Sep 23, 2020
kylezh
kylezh reviewed Sep 23, 2020
View reviewed changes
docs/zbs-csi-driver-deployment.md Outdated

- Kubernetes v1.17 or higher

- ZBS v4.0.8-rc2 or higher
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里要补充一下 4.5 的版本，v4.5.0-rc14，以及对应 ISO 的版本

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯。

Copy link
Contributor Author

@weipengzhu weipengzhu Sep 23, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4.5.0-rc14, 4.0.8-rc2 这两个release 还没有打出 ISO。

docs/zbs-csi-driver-deployment.md
Comment on lines 21 to 22
### Enable Kubernetes features

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里是不是区分一下 k8s 的版本比较合适

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯。

docs/zbs-csi-driver-deployment.md Outdated
```
systemctl status kubelet

kubectl get pod -n kube-system
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有一个kubectl wait 的命令。
另外像这种需要判断以下的，都要给出一个命令行输出作为 example

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯。

docs/zbs-csi-driver-deployment.md Outdated
2. Configure `zbs-cluster-vip` in the access network segment

```sh
zbs-task vip set <zbs-cluster-vip-name> <zbs-cluster-vip>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个必须是 iscsi 吧？可以是其他的么？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

理论上来看只是个 vip，昨天试了下，zbs-task vip set , service name 是可以随便填的。
那规范下，统一成 iscsi。

docs/zbs-csi-driver-deployment.md Outdated
node.startup = manual
```

3. Disable selinux and reboot system
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为什么要 reboot？

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

永久关闭 selinux 只能通过修改配置文件，然后 reboot。
如果想不重启，可以先修改配置文件，然后通过 setenforce 0 暂时关闭 selinux。

docs/zbs-csi-driver-deployment.md Outdated
Comment on lines 164 to 160
```sh
wget https://github.com/iomesh/zbs-csi-driver/archive/master.zip && unzip master.zip && cd zbs-csi-driver-master
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个是不是可以考虑放在 iomesh.com 下面

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯。

docs/zbs-csi-driver-deployment.md Outdated

> **_Note:_ `kubernetes-cluster-id` should be unique and cannot be modified**.

1. Configure controller plugin
2. Download **[zbs-csi-driver](https://github.com/iomesh/zbs-csi-driver/archive/master.zip)**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里用 master 合适么？master 可能不是 stable 的

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯。那就用 v0.1.1 tag 的分支。

@weipengzhu
Copy link
Contributor Author

这个 suffix 要怎么填？
这个是根据用户环境决定的，一般来说 suffix 为 该节点的 hostname。

@weipengzhu
Copy link
Contributor Author

前面带 $ 符号，后面如果 copy 的话会比较麻烦，建议删掉吧。

但这样就不好区分 cmd 和 output 了。

@kylezh
Copy link
Contributor

kylezh commented Sep 23, 2020

前面带 $ 符号，后面如果 copy 的话会比较麻烦，建议删掉吧。

但这样就不好区分 cmd 和 output 了。

有需要的话，用两个 code block 来区分

@fanyang89
Copy link
Contributor

前面带 $ 符号，后面如果 copy 的话会比较麻烦，建议删掉吧。

我觉得还是带上 $ 比较好，就是要避免无脑复制导致误操作的情况。

@weipengzhu
Update CSI Deployment
1d969a6 
1. support CentOS8
2. add Fio example
3. fixes deployment steps
@kylezh kylezh merged commit c5345f7 into master Sep 24, 2020
@kylezh kylezh deleted the csi branch September 24, 2020 07:47
This was referenced Sep 24, 2020
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylezh kylezh kylezh approved these changes

@fanyang89 fanyang89 Awaiting requested review from fanyang89

Assignees

@weipengzhu weipengzhu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@weipengzhu @kylezh @fanyang89