Update mul(self, other): in _tt_base.py to allow multiplication with complex scalars and fix multiplication with torch.Tensor scalars #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to def __mul__(self, other): for multiplication with scalar: - torch.tensor changed to torch.Tensor which is correct as a type. ( isinstance does not work with torch.tensor but does with torch.Tensor) - added complex scalars as a valid option - adjusted description and error message accordingly
ausstein
changed the title
ion-g-ion
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24
Changes to
def mul(self, other):
for multiplication with scalar:
torch.tensor changed to torch.Tensor which is correct as a type. ( isinstance does not work with torch.tensor but does with torch.Tensor)
added complex scalars as a valid option
adjusted description and error message accordingly