Fix for tornado/asyncio.set_event_loop on Windows and Python 3.8 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will check this out ASAP 🎉 |
Closed
|
I'll be finally checking this out today! Will test it locally and if it works I'll be releasing a new version in the next hours. |
|
Just gave this PR a shot locally and it seems to work fine without breaking anything in earlier versions of IDA as well! Thanks for the PR! |
|
Glad it was of use! Thanks you! |
Andoryuuta
added a commit
to Andoryuuta/idacode
that referenced
this pull request
Sep 24, 2020
Python 2 support was broken in PR ioncodes#13 due to a new ascynio import, added interpreter version check to resolve this.
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for tornado/asyncio.set_event_loop on Windows and Python 3.8
Mitigated by setting a default policy during socket setup.