Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small improvements for .gitignore #10

Merged
merged 1 commit into from
May 5, 2015
Merged

Small improvements for .gitignore #10

merged 1 commit into from
May 5, 2015

Conversation

ludovic-gasc
Copy link
Contributor

  1. Add pyvenv and virtualenv environments
  2. drop .coverage because it's already in the list
  3. add IntelliJ IDEA config file

Thanks for the merge.

@ionelmc
Copy link
Owner

ionelmc commented May 5, 2015

Hey, thanks, will merge this soonish. One question tho, AFAIK .gitignore has glob patterns in it, not regexes. That means "." will match a dot. Am I missing something?

@ludovic-gasc
Copy link
Contributor Author

At line 27, you have the exact same line, two times.
In fact, I'd an alert in my IDE for this duplicate.

@ionelmc
Copy link
Owner

ionelmc commented May 5, 2015

Ooops 😁

Thanks again.

ionelmc added a commit that referenced this pull request May 5, 2015
@ionelmc
Merge pull request #10 from Eyepea/master
73d3e0a 
Small improvements for .gitignore
@ionelmc ionelmc merged commit 73d3e0a into ionelmc:master May 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ludovic-gasc @ionelmc