Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New action - UI - to provide interactive visualizer for tracked result #124

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

seniorsolt
Copy link

UI provides the ability to fold and unfold tree elements and a convenient way to look at variables. To avoid making changes to "trace," I use a class attribute "events" to accumulate events tracked through trace, and a class method start() to explicitly start the UI:

import hunter
hunter.trace(action=hunter.actions.UI)

import os
os.path.join('a', 'b')
hunter.stop()
hunter.actions.UI.start()

For the implementation of the UI, I used PyQt5, so the style does not conform to PEP and uses CamelCase for overriding PyQt5 class methods.

I would like to request your review and some feedback.

I'm also unclear about the order of actions when I request to merge. Should I write additional tests, or is it enough to simply run tox on what already exists? Do I need to ensure test coverage in all environments specified in tox.ini?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant