Skip to content

Commit

Permalink
Actually the logging conf doesn't need to be in the critical section.
Browse files Browse the repository at this point in the history
  • Loading branch information
ionelmc committed Oct 26, 2014
1 parent cec1325 commit 35ba118
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/manhole.py
Original file line number Diff line number Diff line change
Expand Up @@ -501,9 +501,9 @@ def install(verbose=True,
with _LOCK:
if _MANHOLE is not None:
raise AlreadyInstalled("Manhole already installed!")
_LOG.configure(verbose, verbose_destination)
_MANHOLE = Manhole()

_LOG.configure(verbose, verbose_destination)
_MANHOLE.configure(**kwargs) # Threads might be started here

This comment has been minimized.

Copy link
@nirs

nirs Oct 26, 2014

Collaborator

Do you want to support reconfiguration of a Manhole instance? If not, I don't see why we should have a configure() method.

This comment has been minimized.

Copy link
@ionelmc

ionelmc Oct 26, 2014

Author Owner

Not really. It's really something internal, you're not expected to configure twice.



Expand Down

0 comments on commit 35ba118

Please sign in to comment.