-
Notifications
You must be signed in to change notification settings - Fork 24
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Actually the logging conf doesn't need to be in the critical section.
- Loading branch information
Showing
1 changed file
with
1 addition
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -501,9 +501,9 @@ def install(verbose=True, | |
with _LOCK: | ||
if _MANHOLE is not None: | ||
raise AlreadyInstalled("Manhole already installed!") | ||
_LOG.configure(verbose, verbose_destination) | ||
_MANHOLE = Manhole() | ||
|
||
_LOG.configure(verbose, verbose_destination) | ||
_MANHOLE.configure(**kwargs) # Threads might be started here | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
ionelmc
Author
Owner
|
||
|
||
|
||
|
Do you want to support reconfiguration of a Manhole instance? If not, I don't see why we should have a configure() method.