Add redirect_stderr option #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds a new redirect_stderr option. When set to False, only
sys.stdout is patched and used for condole output. The default value is
True, keeping the current behavior.
Redirecting stderr can cause the console to become unusable becuase
Python is writing errors to stderr when it cannot raise an exception.
For example, during interpeter shutdown, or when code in __del__ method
raises an exception.
For example, in vdsm, we get this error every few seconds:
Exception RuntimeError: RuntimeError('cannot notify on un-acquired lock',)
in <module 'threading' from '/usr/lib64/python2.7/threading.pyc'> ignored
While fixing such issues may be possible, it may not be practicle in
large code base. Avoding redirection of stderr allow using manhole in
such case.
|
Very nice. Seems travis has some issue with the coveralls package (unrelated). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a new redirect_stderr option. When set to False, only
sys.stdout is patched and used for condole output. The default value is
True, keeping the current behavior.
Redirecting stderr can cause the console to become unusable becuase
Python is writing errors to stderr when it cannot raise an exception.
For example, during interpeter shutdown, or when code in del method
raises an exception.
For example, in vdsm, we get this error every few seconds:
While fixing such issues may be possible, it may not be practicle in
large code base. Avoding redirection of stderr allow using manhole in
such case.