Alternative fix for #58 (double close bug) #60
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if hasattr(client, 'detach'): | ||
| client_fd = client.detach() | ||
| else: | ||
| client_fd = _ORIGINAL_DUP(client.fileno()) |
There was a problem hiding this comment.
When that may happen?
Should it use fileno at all in this case when it leads to known bugs?
There was a problem hiding this comment.
That's what the dup is for, there would be two numbers for the have underlying resource. So there won't be a double close since there would be two different numbers.
There was a problem hiding this comment.
Ah, true, didn't noticed that. Thanks
ionelmc
force-pushed
the
fix-double-close
branch
from
d01185d
to
2672ad6
Compare
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
==========================================
+ Coverage 81.91% 82.87% +0.96%
==========================================
Files 6 6
Lines 1261 1285 +24
Branches 135 140 +5
==========================================
+ Hits 1033 1065 +32
+ Misses 187 181 -6
+ Partials 41 39 -2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #58.