fix(cordova): obey --source-map for production builds

Fixes #93
ionic-team · Mar 21, 2019 · 23481bd · 23481bd
1 parent 8c7a597
commit 23481bd
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/builders/cordova-build/index.ts b/builders/cordova-build/index.ts
@@ -47,6 +47,8 @@ export class CordovaBuildBuilder implements Builder<CordovaBuildBuilderSchema> {
   prepareBrowserConfig(options: CordovaBuildBuilderSchema, browserOptions: BrowserBuilderSchema) {
     const cordovaBasePath = normalize(options.cordovaBasePath ? options.cordovaBasePath : '.');
 
+    browserOptions.sourceMap = options.sourceMap as any;
+
     // We always need to output the build to `www` because it is a hard
     // requirement of Cordova.
     browserOptions.outputPath = join(cordovaBasePath, normalize('www'));

diff --git a/builders/cordova-serve/index.ts b/builders/cordova-serve/index.ts
@@ -37,9 +37,18 @@ export class CordovaServeBuilder implements Builder<CordovaServeBuilderSchema> {
   }
 
   protected _getCordovaBuildConfig(cordovaServeOptions: CordovaServeBuilderSchema): Observable<BuilderConfiguration<CordovaBuildBuilderSchema>> {
-    const { platform, cordovaBasePath, cordovaAssets, cordovaMock, consolelogs, consolelogsPort } = cordovaServeOptions;
+    const {
+      platform,
+      cordovaBasePath,
+      cordovaAssets,
+      cordovaMock,
+      consolelogs,
+      consolelogsPort,
+      sourceMap,
+    } = cordovaServeOptions;
+
     const [ project, target, configuration ] = cordovaServeOptions.cordovaBuildTarget.split(':');
-    const cordovaBuildTargetSpec = { project, target, configuration, overrides: { platform, cordovaBasePath, cordovaAssets, cordovaMock, consolelogs, consolelogsPort } };
+    const cordovaBuildTargetSpec = { project, target, configuration, overrides: { platform, cordovaBasePath, cordovaAssets, cordovaMock, consolelogs, consolelogsPort, sourceMap } };
     const cordovaBuildTargetConfig = this.context.architect.getBuilderConfiguration<CordovaBuildBuilderSchema>(cordovaBuildTargetSpec);
 
     return this.context.architect.getBuilderDescription(cordovaBuildTargetConfig).pipe(