Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate page adds unnecessary padding attribute to ion-content #105

Closed
dotNetkow opened this issue Mar 18, 2019 · 2 comments
Closed

Generate page adds unnecessary padding attribute to ion-content #105

dotNetkow opened this issue Mar 18, 2019 · 2 comments
Labels
released

Comments

@dotNetkow
Copy link
Contributor

The template for a new Ionic page includes an unnecessary "padding" attribute on ion-content. This results in a border around the main Ionic app content that looks "off" and less "app-like."

<ion-content padding>

</ion-content>

To reproduce, run this command:
ionic g page test

Then, open up test.page.html to see the "padding" attribute.
@dotNetkow
Copy link
Contributor Author

Visual Before:
image

After:
image

@dotNetkow dotNetkow mentioned this issue Mar 18, 2019
Merged
@Ionitron
Copy link
Collaborator

🎉 This issue has been resolved in version 1.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dotNetkow @Ionitron