feat(schematics): add custom component schematic #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imhoffd
reviewed
Feb 5, 2019
imhoffd
previously approved these changes
Feb 5, 2019
imhoffd
reviewed
Feb 6, 2019
schematics/component/index.ts
Outdated
| @@ -47,8 +119,7 @@ function addImportToNgModule(options: ComponentOptions): Rule { | |||
| } | |||
| } | |||
| host.commitUpdate(importRecorder); | |||
| return host; | |||
There was a problem hiding this comment.
I presume it wasn't necessary to return host... my bad 😛
There was a problem hiding this comment.
Host should not to return here. We return the host though further up on line 36, after the modifying the fs.
| } | ||
|
|
||
| if (options.entryComponent) { | ||
| // Need to refresh the AST because we overwrote the file in the host. |
There was a problem hiding this comment.
Can't you just commit the update later? Or does this get a bit messy?
There was a problem hiding this comment.
This was copied over from the angular schematic, so Im assuming it's needed. Probably to make sure that the file is properly updated and not overwriting it.
imhoffd
approved these changes
Feb 6, 2019
|
The commit message has usage examples: 527f54e |
Ionitron
added a commit
that referenced
this pull request
Feb 13, 2019
# [1.4.0](v1.3.0...v1.4.0) (2019-02-13) ### Features * **component:** add custom component schematic ([#68](#68)) ([527f54e](527f54e))
|
🎉 This PR is included in version 1.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
wand1252
added a commit
to wand1252/angular-toolkit-develop
that referenced
this pull request
Aug 31, 2022
# [1.4.0](ionic-team/angular-toolkit@v1.3.0...v1.4.0) (2019-02-13) ### Features * **component:** add custom component schematic ([#68](ionic-team/angular-toolkit#68)) ([527f54e](ionic-team/angular-toolkit@527f54e))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #67