Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parameter --copy not working when custom path to resources is used #173

Closed
martinkasa opened this issue Oct 30, 2020 · 1 comment
Closed
Projects

Comments

@martinkasa
Copy link
Contributor

martinkasa commented Oct 30, 2020

cordova-res -v
0.15.1

File structure:

-android
-theme
  -dark 
    -resources
      -icon.png
      -splash.png

With upper file structure, using command

cordova-res android --resources themes/dark/resources --skip-config --copy

I get a lot of errors like this and fileas are not copied:
Error occurred while copying resources/android/splash/drawable-land-mdpi-screen.png

In verbose mode I can see that wrong path is used for generated resource files.

cordova-res:native Copying generated resource from 'resources/android/splash/drawable-land-mdpi-screen.png' to 'android/app/src/main/res/drawable-land-mdpi/splash.png'

The cause of problem is, that paths to resource files are defined in constants here:
https://github.com/ionic-team/cordova-res/blob/b6c1fd030daa12717b605655a1f1637d59f6eef4/src/native.ts#L68-L71

and custom path defined in --resources parameter is not used.

@mlynch
Copy link
Contributor

mlynch commented Oct 2, 2022

Cordova support dropped in @capacitor/assets. Closing...

@mlynch mlynch closed this as not planned Won't fix, can't repro, duplicate, stale Oct 2, 2022
1.0 automation moved this from To do to Done Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
1.0
Done
Development

No branches or pull requests

2 participants