-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Updating to Gradle 8 #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've sent a similar PR that just updates the capacitor-plugin folder using the migrate helper
We can use yours since it also updates the library, but there are some missing or incorrect things.
In all other plugins we used gradle plugin 8.0.0 instead of 8.0.2, I don't think it would be bad to use a different version, but probably for consistency should use the same.
The gradle wrapper should be 8.0.2-all instead of 8.0-bin as 8.0 and 8.0.1 had some bugs.
Also the gradle files should be updated, you can run ./gradlew wrapper --distribution-type all --gradle-version 8.0.2 --warning-mode all
(sometimes need to be run twice for the files to update)
Remove android.enableJetifier=true
from the gradle.properties
files
This PR brings Background Runner inline with other Capacitor 5 plugins.