fix(push-notifications): properly get the configured icon from manifest #1118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcesarmobile
changed the title
mpkasp
added a commit
to mpkasp/capacitor-plugins
that referenced
this pull request
Aug 29, 2022
* chore: Switch back to independent version (ionic-team#1129) * chore: enable nightly releases (ionic-team#1130) * fix(google-maps): Check for WKScrollView and WKChildScrollView (ionic-team#1109) * feat(camera): Add support for iOS limited photo library mode (ionic-team#1125) * chore(camera): remove listener methods (ionic-team#1136) * chore(ci): Unpin @actions/core version (ionic-team#1141) * fix(filesystem): make iOS return proper url on readdir (ionic-team#1142) * chore(release): publish [skip ci] - @capacitor/camera@4.1.0 - @capacitor/filesystem@4.1.0 - @capacitor/google-maps@4.1.0 * fix(push-notifications): properly get the configured icon from manifest (ionic-team#1118) Co-authored-by: jcesarmobile <jcesarmobile@gmail.com> Co-authored-by: jcesarmobile <jcesarmobile@gmail.com> Co-authored-by: Mike Summerfeldt <20338451+IT-MikeS@users.noreply.github.com> Co-authored-by: Joey Pender <joey@ionic.io> Co-authored-by: Github Workflow (on behalf of IT-MikeS) <users.noreply.github.com> Co-authored-by: Koen <koen.cas@gmail.com>
hmaretic24
pushed a commit
to hmaretic24/capacitor-plugins
that referenced
this pull request
Jan 20, 2023
…st (ionic-team#1118) Co-authored-by: jcesarmobile <jcesarmobile@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the option to display the notification locally on android when the application is in the foreground
applicationInfo.metaDatawould always benull. This results in it using the wrong icon.To be honest I'm not familiar enough to know why it fails to retrieve the metaData here. However after some googling the below solution seems to work in my case.