Memory leak?

[aparajita]

https://github.com/ionic-team/capacitor/blob/c3e821ef2a4cf20c31b3b0bd6b9ca95c717b0219/android/capacitor/src/main/java/com/getcapacitor/Splash.java#L41-L42

Android Studio is giving me the following warning about these lines:

Do not place Android context classes in static fields; this is a memory leak

[imhoffd]

@aparajita I assume you're addressing this in your splash screen plugin? Can this be closed?

[aparajita]

@dwieeb Ultimately I'd like to see if we can move the splash code out of core on Android and completely into the plugin, the way it is on iOS. Can you think of a technical reason why this can't be done?

If all of the code is in the instantiated plugin, those warnings go away because it isn't static any more.

[aparajita]

@dwieeb So I moved all of the code in Splash.java into the plugin, and it's working fine. It doesn't appear as soon in the startup, but that can be addressed separately. It's much, much cleaner to have all of the code in the plugin — it can technically be moved into the capacitor-plugins repo now.

[ionitron-bot]

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of the plugin, please create a new issue and ensure the template is fully filled out.