Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(push-notifications): add unregister functions #1498

Merged
merged 7 commits into from
Mar 24, 2023
Merged

feat(push-notifications): add unregister functions #1498

merged 7 commits into from
Mar 24, 2023

Conversation

markemer
Copy link
Contributor

@markemer markemer commented Mar 21, 2023

Closes: #1100, Related to PR #1110 which this supersedes. We can close that PR when this merges.

Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new method needs to be added to the plugin interface in the definitions.ts file
https://github.com/ionic-team/capacitor-plugins/blob/main/push-notifications/src/definitions.ts#L31

And also run npm run build so the method appears in the plugin docs

And would be good if the test app gets updated with a new button on the push notifications page to call the unregister method

@markemer
Copy link
Contributor Author

The new method needs to be added to the plugin interface in the definitions.ts file https://github.com/ionic-team/capacitor-plugins/blob/main/push-notifications/src/definitions.ts#L31

And also run npm run build so the method appears in the plugin docs

And would be good if the test app gets updated with a new button on the push notifications page to call the unregister method

Duh, yeah - I knew a forgot something - I was so preoccupied with thinking I forgot something on the native side, I forgot all the typescript.

@markemer markemer merged commit 878e295 into main Mar 24, 2023
@markemer markemer deleted the WN-701 branch March 24, 2023 20:02
abennouna added a commit to abennouna/capacitor-plugins that referenced this pull request Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete the Push FCM Token to get a new one
3 participants