-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(push-notifications): add unregister functions #1498
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new method needs to be added to the plugin interface in the definitions.ts file
https://github.com/ionic-team/capacitor-plugins/blob/main/push-notifications/src/definitions.ts#L31
And also run npm run build
so the method appears in the plugin docs
And would be good if the test app gets updated with a new button on the push notifications page to call the unregister method
Duh, yeah - I knew a forgot something - I was so preoccupied with thinking I forgot something on the native side, I forgot all the typescript. |
Closes: #1100, Related to PR #1110 which this supersedes. We can close that PR when this merges.