Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@capacitor/google-maps] @googlemaps/js-api-loader: Refactor to importLibrary method #1586

Closed
AE1NS opened this issue May 9, 2023 · 2 comments

Comments

@AE1NS
Copy link
Contributor

AE1NS commented May 9, 2023

Feature Request

Plugin

@capacitor/google-maps: 5.0.0

Description

Instead of the load method, the new importLibrary method should be used to import the google maps instance. This prevents interferences when the developer wants to use @googlemaps/js-api-loader in the main project with different libraries, i.e. to use the geometry API of google.

Platform(s)

Web

Preferred Solution

Instead of setting up the needed libraries in the constructor of the loader and calling the .load() method, its possible to leave the libraries in the loader empty and use the .importLibrary() method with the parameter maps. The result of the method will be the MapsLibrary.

Additional Context

ionic-team/capacitor#6576

@ionitron-bot ionitron-bot bot added the triage label May 9, 2023
@ionitron-bot ionitron-bot bot removed the triage label May 9, 2023
@AE1NS AE1NS changed the title [@capacitor/google-maps] Add ability for plugin to take already instanciated google maps api [@capacitor/google-maps] @googlemaps/js-api-loader: Refactor to importLibrary method Jul 4, 2023
@AE1NS
Copy link
Contributor Author

AE1NS commented Jun 18, 2024

@AE1NS AE1NS closed this as completed Jun 18, 2024
Copy link

ionitron-bot bot commented Jul 3, 2024

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of the plugin, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Jul 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants