Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileDownload catch issue #1698

Closed
justingel opened this issue Jul 24, 2023 · 7 comments · Fixed by #1742
Closed

FileDownload catch issue #1698

justingel opened this issue Jul 24, 2023 · 7 comments · Fixed by #1742

Comments

@justingel
Copy link

Bug Report

Plugin(s)

@capacitor/filesystem

Capacitor Version

Latest Dependencies:

@capacitor/cli: 5.2.2
@capacitor/core: 5.2.2
@capacitor/android: 5.2.2
@capacitor/ios: 5.2.2

Installed Dependencies:

@capacitor/cli: 5.2.2
@capacitor/core: 5.2.2
@capacitor/android: 5.2.2
@capacitor/ios: 5.2.2

Platform(s)

iOS

Current Behavior

When starting a download on iOS (via. Filesystem.downloadFile) and a non-existing url is given, catch is not being thrown.
When i start the same process on android (with the same url), the catch is being thrown.

Expected Behavior

Same behaviour on both systems.

Code Reproduction

image

Other Technical Details

iPhone 13 Pro - iOS 16.3.1

Additional Context

capacitor-community/http#224 - sounded a bit like it?

@Ionitron
Copy link
Collaborator

This issue needs more information before it can be addressed.
In particular, the reporter needs to provide a minimal sample app that demonstrates the issue.
If no sample app is provided within 15 days, the issue will be closed.

Please see the Contributing Guide for how to create a Sample App.

Thanks!
Ionitron 💙

@justingel
Copy link
Author

I don't think this needs further reproduction.

Just take a non-existent URL, for example "https://capacitorjs.com/test/test.zip" and start the download.
On Android, the catch is being thrown - on iOS no error whatsoever.

Even tho the URL is not existent, something is being saved to the filesystem
image

@Ionitron
Copy link
Collaborator

This issue needs more information before it can be addressed.
In particular, the reporter needs to provide a minimal sample app that demonstrates the issue.
If no sample app is provided within 15 days, the issue will be closed.

Please see the Contributing Guide for how to create a Sample App.

Thanks!
Ionitron 💙

@justingel
Copy link
Author

I mean, i hope it helps?
Did it in a few minutes, if you need further elaboration, just tell me

As i said, if the url leads to a 404 page, it should catch the error.

https://github.com/justingel/capacitor-fs-test/tree/master

@ionitron-bot
Copy link

ionitron-bot bot commented Jul 25, 2023

This issue has been labeled as type: bug. This label is added to issues that that have been reproduced and are being tracked in our internal issue tracker.

@TheRealPingWin

This comment was marked as off-topic.

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 6, 2023

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of the plugin, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants