Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove preserveAspectRatio option #24

Closed
imhoffd opened this issue Aug 28, 2020 · 4 comments · Fixed by #807
Closed

remove preserveAspectRatio option #24

imhoffd opened this issue Aug 28, 2020 · 4 comments · Fixed by #807
Assignees
@ikeith
Labels
plugin: camera type: bug A confirmed bug report
Milestone
@capacitor/camera...

Comments

@imhoffd
Copy link
Contributor

imhoffd commented Aug 28, 2020 •
edited by jcesarmobile

preserveAspectRatio is deprecated and not really used, remove before @capacitor/camera 2.0.0 is released
@imhoffd imhoffd mentioned this issue Aug 28, 2020
Closed
@sandstrom
Copy link

Thanks for creating this issue @dwieeb

I'd even consider removing it, because I'd say there is ~0% use for resize without preserved aspect ratio. Less code to maintain.

@imhoffd imhoffd changed the title Swap preserveAspectRatio default Always preserve aspect ratio and remove preserveAspectRatio option Aug 31, 2020
@imhoffd
Copy link
Contributor Author

imhoffd commented Aug 31, 2020

I think you're right. @jcesarmobile What do you think?

@imhoffd imhoffd removed the triage label Sep 1, 2020
This was referenced Jun 1, 2021
Closed
Closed
@jcesarmobile jcesarmobile changed the title Always preserve aspect ratio and remove preserveAspectRatio option remove preserveAspectRatio option Jun 2, 2021
@jcesarmobile jcesarmobile added this to the @capacitor/camera 2.0.0 milestone Jun 2, 2021
@jcesarmobile jcesarmobile mentioned this issue Feb 7, 2022
Merged
@jcesarmobile jcesarmobile added the type: bug A confirmed bug report label Mar 1, 2022
@jcesarmobile
Copy link
Member

It has been removed on 4.0.0 beta 0

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 30, 2022

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of the plugin, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ikeith ikeith

Labels
plugin: camera type: bug A confirmed bug report
Projects
None yet
Milestone
@capacitor/camera 2.0.0
5 participants
@sandstrom @imhoffd @ikeith @jcesarmobile @Ionitron