fix(local-notifications): Make getPending not return already fired notifications #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I've tested and it works, but it adds a ton of complexity and I think using storage.deleteNotification when the notification fires is enough to not show it on pending and I don't see any side effects on doing that.
The only thing is have in mind that should only be deleted if not repeatable, so probably should be done inside of the rescheduleNotificationIfNeeded method or make it return a boolean to know if it was rescheduled or not and delete it only if not rescheduled
…team/capacitor-plugins into local-notifications-pending-fired
|
Thanks - just deleting the notification worked just as well without any issues! |
jcesarmobile
approved these changes
Feb 18, 2021
jcesarmobile
changed the title
…team/capacitor-plugins into local-notifications-pending-fired
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds changes to the local-notification plugin to filter out already fired notifications from the getPending notifications call.
Since Capacitor supports Android API 21+, we can't rely on
NotificationManager.getActiveNotifications()to easily get a list of notifications in the status bar. Instead, this PR sets avisibleflag on each LocalNotification that gets set when a notification is fired, then cleared when a notification is interacted with.fixes: #221