Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(keyboard): Add default style option for setStyle #334

Merged
merged 1 commit into from
Apr 7, 2021

Conversation

jcesarmobile
Copy link
Member

Default will be the default as, at the moment, we are preventing the keyboard style to change based on the device appearance.
Users can still change the values programmatically to any of the three possible values (dark, light or default), and the configuration allows to set to always light or always dark if their app doesn't react to device appearance changes.

closes #318

@jcesarmobile jcesarmobile requested a review from ikeith April 1, 2021 17:44
@Ionitron Ionitron added this to Needs review 🤔 in Capacitor Engineering ⚡️ Apr 1, 2021
@jcesarmobile jcesarmobile merged commit 9dbb809 into main Apr 7, 2021
Capacitor Engineering ⚡️ automation moved this from Needs review 🤔 to Done 🎉 Apr 7, 2021
@jcesarmobile jcesarmobile deleted the kb-default branch April 7, 2021 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Allow for automtically configuring keybaord to match device appearance
2 participants