Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(geolocation): Use the new APIs for handling/saving calls #374

Merged
merged 4 commits into from
May 6, 2021
Merged

fix(geolocation): Use the new APIs for handling/saving calls #374

merged 4 commits into from
May 6, 2021

Conversation

jcesarmobile
Copy link
Member

closes #362

@jcesarmobile jcesarmobile requested a review from ikeith May 5, 2021 11:23
@Ionitron Ionitron added this to Needs review 🤔 in Capacitor Engineering ⚡️ May 5, 2021
@jcesarmobile jcesarmobile mentioned this pull request May 5, 2021
Closed
@jcesarmobile
Copy link
Member Author

replaced the keepAlive with bridge?.saveCall(call) for permissions and getCurrentPosition methods as keepAlive is supposed for multiple results and saveCall for single result.

Won't work until the linked issue get fixed (working on it at the moment)

@jcesarmobile jcesarmobile requested a review from ikeith May 5, 2021 17:48
@jcesarmobile jcesarmobile mentioned this pull request May 6, 2021
Merged
@jcesarmobile jcesarmobile merged commit ebd5b52 into main May 6, 2021
Capacitor Engineering ⚡️ automation moved this from Needs review 🤔 to Done 🎉 May 6, 2021
@jcesarmobile jcesarmobile deleted the remove-deprecated-geolocation branch May 6, 2021 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikeith ikeith ikeith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Capacitor Engineering ⚡️
  
Done 🎉
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

geolocation plugin shows warnings
2 participants
@jcesarmobile @ikeith